Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#915 | abstract the network configuration for easiest multichain support #917

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Dec 20, 2024

Fixes #915

Description

This PR refactorizes the configuration files to be clear the data needed and variable for each network.

It also adds a third network configuration temporally for zkEVM network. You need to run locally an indexer and wait for it to sync and then put up the API endpoint.

@Viterbo Viterbo linked an issue Dec 20, 2024 that may be closed by this pull request
@Viterbo Viterbo self-assigned this Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for teloscan ready!

Name Link
🔨 Latest commit 8c3018d
🔍 Latest deploy log https://app.netlify.com/sites/teloscan/deploys/676af5e6e848ee0008ba0041
😎 Deploy Preview https://deploy-preview-917--teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit 8c3018d
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/676af5e647437300080e5222
😎 Deploy Preview https://deploy-preview-917--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo closed this Dec 20, 2024
@Viterbo Viterbo reopened this Dec 20, 2024
@Viterbo Viterbo marked this pull request as draft December 20, 2024 23:40
Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for zkevm-testnet ready!

Name Link
🔨 Latest commit 8c3018d
🔍 Latest deploy log https://app.netlify.com/sites/zkevm-testnet/deploys/676af5e6279ccb0008513964
😎 Deploy Preview https://deploy-preview-917--zkevm-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbuice jbuice marked this pull request as ready for review December 21, 2024 16:17
@Viterbo Viterbo changed the base branch from master to dev December 24, 2024 18:01
Copy link
Member

@poplexity poplexity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@poplexity poplexity merged commit 6e3f72b into dev Dec 24, 2024
13 checks passed
@poplexity poplexity deleted the 915-abstract-the-network-configuration-for-easiest-multichain-support branch December 24, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract the Network configuration for easiest multichain support
3 participants