-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#915 | abstract the network configuration for easiest multichain support #917
Merged
poplexity
merged 14 commits into
dev
from
915-abstract-the-network-configuration-for-easiest-multichain-support
Dec 24, 2024
Merged
#915 | abstract the network configuration for easiest multichain support #917
poplexity
merged 14 commits into
dev
from
915-abstract-the-network-configuration-for-easiest-multichain-support
Dec 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…15-abstract-the-network-configuration-for-easiest-multichain-support
✅ Deploy Preview for teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zkevm-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
poplexity
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
poplexity
deleted the
915-abstract-the-network-configuration-for-easiest-multichain-support
branch
December 24, 2024 18:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #915
Description
This PR refactorizes the configuration files to be clear the data needed and variable for each network.
It also adds a third network configuration temporally for zkEVM network. You need to run locally an indexer and wait for it to sync and then put up the API endpoint.